Move apps tests from c/b/extensions to c/b/apps and refine DEPS.

Move apps tests from c/b/extensions to c/b/apps and refine DEPS.

TBR=sky
BUG=159366
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217780

[tapted, 2013-08-14 01:55:45]

lgtm

https://codereview.chromium.org/23003004/diff/1/chrome/browser/apps/app_brows...
File chrome/browser/apps/app_browsertest_util.h (right):

https://codereview.chromium.org/23003004/diff/1/chrome/browser/apps/app_brows...
chrome/browser/apps/app_browsertest_util.h:7: 
nit: there's an extra line here

https://codereview.chromium.org/23003004/diff/1/chrome/browser/apps/app_brows...
chrome/browser/apps/app_browsertest_util.h:18: namespace extensions {
Should we move extensions::PlatformAppBrowserTest to apps:PlatformAppBrowserTest
? I'm leaning towards 'no' or 'not yet', but I thought I'd ask

https://codereview.chromium.org/23003004/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/23003004/diff/1/chrome/chrome_tests.gypi#newc...
chrome/chrome_tests.gypi:1170: 'browser/apps/web_view_browsertest.cc',
nit: web_view_browsertest before window_controls_browsertest

[tapted, 2013-08-14 02:47:21]

https://codereview.chromium.org/23003004/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/23003004/diff/1/chrome/chrome_tests.gypi#newc...
chrome/chrome_tests.gypi:209: 'browser/apps/app_browsertest_util.cc',
actually - should this go in the test_support_common target, in the gypi ? I
think with the current way, it get unnecessarily compiled twice. There's already
some extensiony things there, but it might still need a platform exclusion..

[tapted, 2013-08-14 02:49:34]

On 2013/08/14 02:47:21, tapted wrote:
> the test_support_common target, in the gypi

chrome_tests_unit.gypi that is. It's described

      # This target contains mocks and test utilities that don't belong in
      # production libraries but are used by more than one test executable.
      'target_name': 'test_support_common',

[benwells, 2013-08-15 02:00:50]

On 2013/08/14 02:49:34, tapted wrote:
> On 2013/08/14 02:47:21, tapted wrote:
> > the test_support_common target, in the gypi
> 
> chrome_tests_unit.gypi that is. It's described
> 
>       # This target contains mocks and test utilities that don't belong in
>       # production libraries but are used by more than one test executable.
>       'target_name': 'test_support_common',

I'm gonna update the namespace separately.

Also, the util module depends on the extensions_apitest, which is also compiled
into both those targets. They should come out together; that should happen
separately too.

[benwells, 2013-08-15 02:01:35]

TBR sky for refactoring fallout

[commit-bot: I haz the power, 2013-08-15 02:01:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/23003004/21001

[commit-bot: I haz the power, 2013-08-15 11:27:01]

Change committed as 217780