Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2299963002: Reland "Change ProxyResolver::GetProxyForURL() to take a unique_ptr<Request>* " (Closed)
Patch Set: remove fields proposed by eroman Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 230fe559c2a9615915b153a10f29a2c67fd60891..e2397215272d8e11a951547b5266654d1064cb28 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -11076,7 +11076,7 @@ class CapturingProxyResolver : public ProxyResolver {
int GetProxyForURL(const GURL& url,
ProxyInfo* results,
const CompletionCallback& callback,
- RequestHandle* request,
+ std::unique_ptr<Request>* request,
const NetLogWithSource& net_log) override {
ProxyServer proxy_server(ProxyServer::SCHEME_HTTP,
HostPortPair("myproxy", 80));
@@ -11085,13 +11085,6 @@ class CapturingProxyResolver : public ProxyResolver {
return OK;
}
- void CancelRequest(RequestHandle request) override { NOTREACHED(); }
-
- LoadState GetLoadState(RequestHandle request) const override {
- NOTREACHED();
- return LOAD_STATE_IDLE;
- }
-
const std::vector<GURL>& resolved() const { return resolved_; }
private:
« no previous file with comments | « content/browser/resolve_proxy_msg_helper_unittest.cc ('k') | net/http/http_stream_factory_impl_job_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698