Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 22999048: Revert "Get rid of ConvertFieldToDescriptor and simplify related code." (Closed)

Created:
7 years, 4 months ago by Toon Verwaest
Modified:
7 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Revert "Get rid of ConvertFieldToDescriptor and simplify related code." R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -90 lines) Patch
M src/objects.h View 5 chunks +12 lines, -8 lines 0 comments Download
M src/objects.cc View 12 chunks +71 lines, -73 lines 0 comments Download
M src/objects-inl.h View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 4 months ago (2013-08-23 13:17:37 UTC) #1
rossberg
lgtm
7 years, 4 months ago (2013-08-23 13:18:12 UTC) #2
Toon Verwaest
7 years, 4 months ago (2013-08-23 13:21:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16297.

Powered by Google App Engine
This is Rietveld 408576698