Assert that loading is complete in SVGImage::hasSingleSecurityOrigin()

Assert that loading is complete in SVGImage::hasSingleSecurityOrigin()

This patch adds an assert that the "inner page" in an SVGImage has
loaded and does not have any pending subresource loads.

NOTRY=true
BUG=249037
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157433

[pdr., 2013-08-21 05:36:23]

@abarth, we talked about checking if the document readyState was >= Interactive
but in writing this patch I realized it's not enough. Those readyStates could be
true with a subresource still loading, meaning hasSingleSecurityOrigin() would
not check everything. Of course, subresources are disabled for SVG images but
this is for futureproofing this code.

I've added a check that the DocumentLoader is not loading, but I'm not familiar
enough with the loader to know if this will cover everything.

[abarth-chromium, 2013-08-21 17:07:31]

LGTM

https://codereview.chromium.org/22999031/diff/1/Source/core/svg/graphics/SVGI...
File Source/core/svg/graphics/SVGImage.cpp (right):

https://codereview.chromium.org/22999031/diff/1/Source/core/svg/graphics/SVGI...
Source/core/svg/graphics/SVGImage.cpp:87:
RELEASE_ASSERT(!frame->loader()->activeDocumentLoader()->isLoading());
If you want to do things this way, the best check is probably:

RELEASE_ASSERT(frame->document()->loadEventFinished());

That will become true once we're done firing the load event for the given
document.

[commit-bot: I haz the power, 2013-08-21 18:07:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/22999031/1002

[commit-bot: I haz the power, 2013-08-21 18:33:01]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-08-21 18:37:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/22999031/1002

[commit-bot: I haz the power, 2013-08-21 19:10:28]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-09-09 02:58:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/22999031/1002

[commit-bot: I haz the power, 2013-09-09 04:20:30]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-09-09 04:35:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/22999031/1002

[commit-bot: I haz the power, 2013-09-09 04:37:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/22999031/1002

[commit-bot: I haz the power, 2013-09-09 04:37:50]

Change committed as 157433