Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 22998004: Rename speech_recognition_browsertest to input_tag_speech_browsertest. (Closed)

Created:
7 years, 4 months ago by janx
Modified:
7 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename speech_recognition_browsertest to input_tag_speech_browsertest. These browsertests only handle input tags with x-webkit-speech, and should be removed once we drop support for that feature. Renaming the file makes this more obvious, and also avoids confusion with the Web Speech API, for which a new speech_recognition_browsertest will be implemented. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223579

Patch Set 1 #

Patch Set 2 : Also rename class to InputTagSpeechBrowserTest. #

Patch Set 3 : Rebased to HEAD. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -142 lines) Patch
A + content/browser/speech/input_tag_speech_browsertest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
D content/browser/speech/speech_recognition_browsertest.cc View 1 2 1 chunk +0 lines, -136 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
janx
Just renaming, nothing too exciting.
7 years, 4 months ago (2013-08-20 16:53:43 UTC) #1
Avi (use Gerrit)
LGTM
7 years, 3 months ago (2013-09-16 16:23:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/22998004/9001
7 years, 3 months ago (2013-09-16 16:24:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79430
7 years, 3 months ago (2013-09-16 22:25:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/janx@chromium.org/22998004/9001
7 years, 3 months ago (2013-09-17 10:53:29 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 11:51:57 UTC) #6
Message was sent while issue was closed.
Change committed as 223579

Powered by Google App Engine
This is Rietveld 408576698