Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2299613004: Converted Observatory timeline-page element (Closed)
Patch Set: Avoid to detached the iframe during rendering Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index b2d7e76ef50efb9660573498011b7d56a5ffdbab..7317fd9aff6aad47855dfc7b1cef86e658f7f04d 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -776,14 +776,11 @@ class TimelinePage extends Page {
TimelinePage(app) : super(app);
void onInstall() {
- if (element == null) {
- element = new Element.tag('timeline-page');
- }
- assert(element != null);
+ element = new TimelinePageElement(app.vm, app.events, app.notifications,
+ queue: app.queue);
}
void _visit(Uri uri) {
- assert(element != null);
assert(canVisit(uri));
}

Powered by Google App Engine
This is Rietveld 408576698