Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 22992003: Moved chrome/browser/ui/extensions apps code to chrome/browser/ui/apps (Closed)

Created:
7 years, 4 months ago by benwells
Modified:
7 years, 4 months ago
Reviewers:
tapted, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, jeremya+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Moved chrome/browser/ui/extensions apps code to chrome/browser/ui/apps This is part of the ongoing effort to extract apps code from extensions. TBR=sky BUG=159366 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217512

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unfashionable namespace #

Patch Set 3 : Fixed stuffup #

Patch Set 4 : Rebase #

Patch Set 5 : Win compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -248 lines) Patch
M apps/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M apps/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/apps/app_metro_infobar_delegate_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/apps/app_metro_infobar_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/apps/apps_metro_handler_win.h View 1 1 chunk +3 lines, -7 lines 0 comments Download
A + chrome/browser/ui/apps/apps_metro_handler_win.cc View 1 2 3 4 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/extensions/app_metro_infobar_delegate_win.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/extensions/app_metro_infobar_delegate_win.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/ui/extensions/apps_metro_handler_win.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/extensions/apps_metro_handler_win.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
benwells
7 years, 4 months ago (2013-08-13 07:40:54 UTC) #1
tapted
lgtm, unless you want to do the comment, in which case lgtm with nits https://codereview.chromium.org/22992003/diff/1/chrome/browser/ui/apps/apps_metro_handler_win.h ...
7 years, 4 months ago (2013-08-13 07:45:21 UTC) #2
benwells
https://codereview.chromium.org/22992003/diff/1/chrome/browser/ui/apps/apps_metro_handler_win.h File chrome/browser/ui/apps/apps_metro_handler_win.h (right): https://codereview.chromium.org/22992003/diff/1/chrome/browser/ui/apps/apps_metro_handler_win.h#newcode10 chrome/browser/ui/apps/apps_metro_handler_win.h:10: namespace chrome { On 2013/08/13 07:45:22, tapted wrote: > ...
7 years, 4 months ago (2013-08-13 08:25:45 UTC) #3
benwells
+TBR sky for refactoring fallout in chrome/browser/ui/browser_command_controller.cc
7 years, 4 months ago (2013-08-13 08:27:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/22992003/17001
7 years, 4 months ago (2013-08-13 08:27:23 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-13 08:42:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/22992003/17001
7 years, 4 months ago (2013-08-13 21:58:29 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-13 23:12:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/22992003/48001
7 years, 4 months ago (2013-08-14 06:43:07 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=159071
7 years, 4 months ago (2013-08-14 07:49:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/22992003/48001
7 years, 4 months ago (2013-08-14 08:55:56 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 09:53:57 UTC) #12
Message was sent while issue was closed.
Change committed as 217512

Powered by Google App Engine
This is Rietveld 408576698