Issue 22989006: [telemetry] Change many relative paths to use util.Get*Dir().

Issue 22989006: [telemetry] Change many relative paths to use util.Get*Dir(). (Closed)

Created:
7 years, 4 months ago by dtu

Modified:
7 years, 4 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Change many relative paths to use util.Get*Dir(). In particular, there are a lot of relative references to unittest_data/. Moving these source files would cause problems. BUG=None. TEST=./run_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218748

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -2622 lines)			Patch
M	tools/telemetry/telemetry/core/browser_credentials.py	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/core/browser_unittest.py	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_browser_finder.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/form_based_credentials_backend_unittest_base.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/inspector_memory_unittest.py	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/inspector_page_unittest.py	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/inspector_timeline_unittest.py	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/tracing_backend_unittest.py	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/extension_unittest.py	View		6 chunks	+9 lines, -13 lines	0 comments	Download
M	tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
D	tools/telemetry/telemetry/core/platform/profiler/testdata/perf_report_output.txt	View	1	1 chunk	+0 lines, -2497 lines	0 comments	Download
M	tools/telemetry/telemetry/core/profile_types.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/tab_unittest.py	View		3 chunks	+4 lines, -10 lines	0 comments	Download
M	tools/telemetry/telemetry/core/temporary_http_server_unittest.py	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/all_page_actions.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/click_element_unittest.py	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/navigate_unittest.py	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/scroll.py	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/scroll_unittest.py	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/wait_unittest.py	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement_unittest_base.py	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_runner_unittest.py	View		5 chunks	+6 lines, -18 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_test_unittest.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A +	tools/telemetry/unittest_data/perf_report_output.txt	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dtu

Another cleanup before https://codereview.chromium.org/23072018/ can happen.

7 years, 4 months ago (2013-08-20 07:39:08 UTC) #1

tonyg

lgtm! Another stellar cleanup. Thank you. FYI, I renamed the perf.profile test data, so that ...

7 years, 4 months ago (2013-08-20 15:30:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/22989006/5001

7 years, 4 months ago (2013-08-21 06:53:14 UTC) #3

Message was sent while issue was closed.

Change committed as 218748

Expand Messages | Collapse Messages