Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 22984009: Merged r16150, r16174, r16175 into 3.19 branch. (Closed)

Created:
7 years, 4 months ago by Yang
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Merged r16150, r16174, r16175 into 3.19 branch. Fix regressions triggered by map invalidation during graph creation. Fix bug in HPhi::SimplifyConstantInput. Use Cell instead of PropertyCell in DoCheckFunction (in case of new space object). R=jkummerow@chromium.org BUG=269679 Committed: https://code.google.com/p/v8/source/detail?r=16217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -73 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assert-scope.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler.h View 3 chunks +10 lines, -6 lines 0 comments Download
M src/compiler.cc View 6 chunks +12 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-map-invalidation-1.js View 1 chunk +15 lines, -6 lines 0 comments Download
A + test/mjsunit/regress/regress-map-invalidation-2.js View 1 chunk +17 lines, -12 lines 0 comments Download
A + test/mjsunit/regress/regress-phi-truncation.js View 1 chunk +49 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 4 months ago (2013-08-19 11:00:31 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-19 11:04:16 UTC) #2
Yang
7 years, 4 months ago (2013-08-19 11:18:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698