Disable non Latin keyboard layout on Lock screen and Sign-in screen.

Disable non Latin keyboard layout on Lock screen and Sign-in screen.

The information about the keyboard layout can be used on login screen is pure
static, so it is good to handle as attribute of input method.
With this change non-Latin keyboard like Russian keyboard won't be enabled on
Lock screen.

BUG=278711
TEST=Manually checked on link

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220226

[Seigo Nonaka, 2013-08-20 12:17:20]

Hi Zach, could you take a look?

Thank you.

[Seigo Nonaka, 2013-08-21 22:56:42]

friendly ping

[Zachary Kuznia, 2013-08-21 23:13:21]

lgtm with nit

https://codereview.chromium.org/22980018/diff/2001/chromeos/ime/input_methods...
File chromeos/ime/input_methods.txt (right):

https://codereview.chromium.org/22980018/diff/2001/chromeos/ime/input_methods...
chromeos/ime/input_methods.txt:21: #              scren.
s/scren/screen/

[Seigo Nonaka, 2013-08-21 23:55:31]

Thank you for your review!

https://codereview.chromium.org/22980018/diff/2001/chromeos/ime/input_methods...
File chromeos/ime/input_methods.txt (right):

https://codereview.chromium.org/22980018/diff/2001/chromeos/ime/input_methods...
chromeos/ime/input_methods.txt:21: #              scren.
On 2013/08/21 23:13:21, Zachary Kuznia wrote:
> s/scren/screen/

Done.

[Seigo Nonaka, 2013-08-21 23:59:13]

Adding nkostylev@ as the owner of chromeos login.

Hi Nikita, could you take an owner review of

- chrome/browser/chromeos/login/user_manager_impl.cc
- chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
-
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc

Thank you.

[Nikita (slow), 2013-08-22 14:33:41]

Please link to existing BUG or create a new one.

I guess this improves what was done for
https://code.google.com/p/chromium/issues/detail?id=152843

[Nikita (slow), 2013-08-22 14:39:57]

+Alexander

lgtm

https://codereview.chromium.org/22980018/diff/8001/chrome/browser/ui/webui/op...
File
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc
(right):

https://codereview.chromium.org/22980018/diff/8001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc:53:
true,
nit: Please add comment for boolean value.

https://codereview.chromium.org/22980018/diff/8001/chromeos/ime/input_method_...
File chromeos/ime/input_method_descriptor.h (right):

https://codereview.chromium.org/22980018/diff/8001/chromeos/ime/input_method_...
chromeos/ime/input_method_descriptor.h:62: bool is_login_keyboard_;
nit: Please add comment.

[Alexander Alekseev, 2013-08-22 20:18:23]

By now we probably have all "login screen allowed" layouts. Most of layouts we
don't have cannot be used at login screen.

You added flag to "prohibit" using some layout at login screen. Wouldn't be
better intead to have flag to "allow" using some keyboard layout? I'm a bit
afraid that we allow new layouts by default and it might lead to unsuitable one
allowed.

[Seigo Nonaka, 2013-08-24 07:57:01]

Update to make deny on login screen by default.

PTAL?

Thank you.

https://codereview.chromium.org/22980018/diff/8001/chrome/browser/ui/webui/op...
File
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc
(right):

https://codereview.chromium.org/22980018/diff/8001/chrome/browser/ui/webui/op...
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc:53:
true,
On 2013/08/22 14:39:57, Nikita Kostylev wrote:
> nit: Please add comment for boolean value.

Done.

https://codereview.chromium.org/22980018/diff/8001/chromeos/ime/input_method_...
File chromeos/ime/input_method_descriptor.h (right):

https://codereview.chromium.org/22980018/diff/8001/chromeos/ime/input_method_...
chromeos/ime/input_method_descriptor.h:62: bool is_login_keyboard_;
On 2013/08/22 14:39:57, Nikita Kostylev wrote:
> nit: Please add comment.

Done.

[Alexander Alekseev, 2013-08-26 17:11:27]

lgtm

[Alexander Alekseev, 2013-08-26 17:12:01]

Thank you for update.

[Seigo Nonaka, 2013-08-27 00:44:21]

Thank you for your review!
Submitting...

[commit-bot: I haz the power, 2013-08-27 00:54:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/22980018/13001

[commit-bot: I haz the power, 2013-08-27 04:02:53]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Seigo Nonaka, 2013-08-28 09:39:26]

Adding mpcomplete@ as the owner of extension test cases.

Hi Matt, could you take an owner review?

- chrome/test/data/extensions/api_test/input_method/background.js
- chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc

I changed to disable non-latin keybaords on Login screen.
Here, the Russian keyboard is not good for expectation because input method
manager consider as loging mode without any notification. So I changed the
expectation to French keyboard.

Thank you.
Seigo.

[Matt Perry, 2013-08-28 20:02:20]

lgtm

[commit-bot: I haz the power, 2013-08-29 00:13:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/22980018/67001

[commit-bot: I haz the power, 2013-08-29 08:59:00]

Change committed as 220226