Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 22976005: Android: Set GOMA_COMPILER_PROXY_THREADS to a reasonable value (Closed)

Created:
7 years, 4 months ago by Anton
Modified:
6 years, 11 months ago
Reviewers:
bulach, Nico, anton1
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Set GOMA_COMPILER_PROXY_THREADS to a reasonable value BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/android/envsetup.sh View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
anton1
7 years, 4 months ago (2013-08-21 13:08:42 UTC) #1
bulach
lgtm, thanks!
7 years, 4 months ago (2013-08-21 15:04:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/22976005/1
7 years, 4 months ago (2013-08-21 15:15:59 UTC) #3
commit-bot: I haz the power
Change committed as 218803
7 years, 4 months ago (2013-08-21 19:47:24 UTC) #4
Nico
6 years, 11 months ago (2014-01-18 19:00:31 UTC) #5
Message was sent while issue was closed.
Hi,

I'm undoing this change in https://codereview.chromium.org/142393002/ – this
kind of tweaking should be done in goma itself, not in every client.

Sadly, the CL description didn't say what the impact of this change was.

Nico

Powered by Google App Engine
This is Rietveld 408576698