Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9209)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.cc

Issue 22975006: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for regression bug Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/content_setting_bubble_contents.cc
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc
index 87f56c898b1129c549a814d27faee7fb1e06e7f2..db1ac258bd28bea5bf964c7450e397f5f9773736 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.cc
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc
@@ -148,7 +148,9 @@ ContentSettingBubbleContents::ContentSettingBubbleContents(
web_contents_(web_contents),
custom_link_(NULL),
manage_link_(NULL),
- close_button_(NULL) {
+ close_button_(NULL),
+ never_button_(NULL),
+ save_button_(NULL) {
// Compensate for built-in vertical padding in the anchor view's image.
set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
@@ -389,22 +391,57 @@ void ContentSettingBubbleContents::Init() {
layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
}
- const int kDoubleColumnSetId = 1;
- views::ColumnSet* double_column_set =
- layout->AddColumnSet(kDoubleColumnSetId);
- double_column_set->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 1,
- GridLayout::USE_PREF, 0, 0);
- double_column_set->AddPaddingColumn(
- 0, views::kUnrelatedControlHorizontalSpacing);
- double_column_set->AddColumn(GridLayout::TRAILING, GridLayout::CENTER, 0,
- GridLayout::USE_PREF, 0, 0);
-
- layout->StartRow(0, kDoubleColumnSetId);
- manage_link_ = new views::Link(UTF8ToUTF16(bubble_content.manage_link));
- manage_link_->set_listener(this);
- layout->AddView(manage_link_);
- if (content_setting_bubble_model_->content_type() !=
+ if (content_setting_bubble_model_->content_type() ==
CONTENT_SETTINGS_TYPE_SAVE_PASSWORD) {
+ const int kDoubleColumnSetId = 2;
+ views::ColumnSet* double_column_set =
+ layout->AddColumnSet(kDoubleColumnSetId);
+ double_column_set->AddColumn(GridLayout::TRAILING, GridLayout::CENTER, 1,
+ GridLayout::USE_PREF, 0, 0);
+ double_column_set->AddPaddingColumn(
+ 0, views::kRelatedControlSmallVerticalSpacing);
+ double_column_set->AddColumn(GridLayout::TRAILING, GridLayout::CENTER, 0,
+ GridLayout::USE_PREF, 0, 0);
+
+ const int kSingleColumnRightSetId = 1;
+ views::ColumnSet* right_column_set =
+ layout->AddColumnSet(kSingleColumnRightSetId);
+ right_column_set->AddColumn(GridLayout::TRAILING, GridLayout::FILL, 1,
+ GridLayout::USE_PREF, 0, 0);
+
+ never_button_ = new views::LabelButton(
+ this, l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_BLACKLIST_BUTTON));
+ never_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
+ save_button_ = new views::LabelButton(
+ this, l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SAVE_BUTTON));
+ save_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
+ manage_link_ = new views::Link(UTF8ToUTF16(bubble_content.manage_link));
+ manage_link_->set_listener(this);
+
+ // Buttons row
+ layout->StartRow(0, kDoubleColumnSetId);
+ layout->AddView(never_button_);
+ layout->AddView(save_button_);
+
+ // Manage link row
+ layout->StartRow(0, kSingleColumnRightSetId);
+ layout->AddView(manage_link_);
+ } else {
+ const int kDoubleColumnSetId = 1;
+ views::ColumnSet* double_column_set =
+ layout->AddColumnSet(kDoubleColumnSetId);
+ double_column_set->AddColumn(GridLayout::LEADING, GridLayout::CENTER, 1,
+ GridLayout::USE_PREF, 0, 0);
+ double_column_set->AddPaddingColumn(
+ 0, views::kUnrelatedControlHorizontalSpacing);
+ double_column_set->AddColumn(GridLayout::TRAILING, GridLayout::CENTER, 0,
+ GridLayout::USE_PREF, 0, 0);
+
+ layout->StartRow(0, kDoubleColumnSetId);
+ manage_link_ = new views::Link(UTF8ToUTF16(bubble_content.manage_link));
+ manage_link_->set_listener(this);
+ layout->AddView(manage_link_);
+
close_button_ =
new views::LabelButton(this, l10n_util::GetStringUTF16(IDS_DONE));
close_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
@@ -414,6 +451,16 @@ void ContentSettingBubbleContents::Init() {
void ContentSettingBubbleContents::ButtonPressed(views::Button* sender,
const ui::Event& event) {
+ if (sender == save_button_) {
+ content_setting_bubble_model_->OnSaveClicked();
+ StartFade(false);
+ return;
+ }
+ if (sender == never_button_) {
+ content_setting_bubble_model_->OnCancelClicked();
+ StartFade(false);
+ return;
+ }
if (sender == close_button_) {
content_setting_bubble_model_->OnDoneClicked();
StartFade(false);
« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698