Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 22969004: Fix a host permissions typo in docs (Closed)

Created:
7 years, 4 months ago by vabr (Chromium)
Modified:
7 years, 4 months ago
Reviewers:
Mike West
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix a host permissions typo in docs In http://developer.chrome.com/extensions/declarativeWebRequest.html we list an incorrectly formatted host permission, missing the "/*" for path. This CL fixes it, and also changes the example host permission for the declarativeWebRequest API from *.google.com to all hosts, because that's what is needed for most actions. NOTRY=true BUG=267639 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vabr (Chromium)
Hi Mike, PTAL. Vaclav
7 years, 4 months ago (2013-08-22 08:51:26 UTC) #1
Mike West
LGTM. Thanks!
7 years, 4 months ago (2013-08-22 09:01:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/22969004/1
7 years, 4 months ago (2013-08-22 09:03:53 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 09:30:08 UTC) #4
Message was sent while issue was closed.
Change committed as 218972

Powered by Google App Engine
This is Rietveld 408576698