Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 22969002: Add stats js files to static dir (Closed)

Created:
7 years, 4 months ago by Isaac (away)
Modified:
7 years, 4 months ago
Reviewers:
agable
CC:
chromium-reviews, cmp+cc_chromium.org, iannucci
Visibility:
Public.

Description

Add stats js files to static dir build.chromium.org does not use https, so masters that serve over https will soon need a more secure source. Add these to chromium-build for convenience. Examples of current use: http://build.chromium.org/p/chromium/stats/Mac http://build.chromium.org/mochikit/MochiKit.js R=agable@chromium.org BUG=229595 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10067 lines, -0 lines) Patch
A static/js/mochikit/MochiKit.js View 1 chunk +7845 lines, -0 lines 0 comments Download
A static/js/mochikit/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
A static/js/plotkit/Base.js View 1 chunk +401 lines, -0 lines 0 comments Download
A static/js/plotkit/Canvas.js View 1 chunk +682 lines, -0 lines 0 comments Download
A static/js/plotkit/LICENSE View 1 chunk +30 lines, -0 lines 0 comments Download
A static/js/plotkit/Layout.js View 1 chunk +753 lines, -0 lines 0 comments Download
A static/js/plotkit/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
A static/js/plotkit/SweetCanvas.js View 1 chunk +348 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Isaac (away)
7 years, 4 months ago (2013-08-12 22:53:36 UTC) #1
agable
On 2013/08/12 22:53:36, Isaac wrote: LGTM. If we can get all of the masters to ...
7 years, 4 months ago (2013-08-13 19:03:48 UTC) #2
Isaac (away)
Committed patchset #1 manually as r217303 (presubmit successful).
7 years, 4 months ago (2013-08-13 19:14:27 UTC) #3
Isaac (away)
Aaron, could you ping this review when you get a chance to upload this to ...
7 years, 4 months ago (2013-08-13 19:15:26 UTC) #4
Isaac (away)
Ping. Still waiting on a chromium-build push.
7 years, 4 months ago (2013-08-20 06:13:31 UTC) #5
agable
7 years, 4 months ago (2013-08-22 14:14:18 UTC) #6
Message was sent while issue was closed.
On 2013/08/20 06:13:31, Isaac wrote:
> Ping.  Still waiting on a chromium-build push.

Done.

Powered by Google App Engine
This is Rietveld 408576698