Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 22966010: Call RecordLastRunAppBundlePath in FILE thread (Closed)

Created:
7 years, 4 months ago by Jiang Jiang
Modified:
7 years, 3 months ago
Reviewers:
sail, benwells, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Call RecordLastRunAppBundlePath in FILE thread RecordLastRunAppBundlePath() uses chrome::GetVersionedDirectory() which in turn uses PathProvider for base::DIR_EXE, which will do I/O on OS X since it uses base::MakeAbsoluteFilePath() now. Reorder the sync call a bit so that we don't have to post another FILE thread task to get the preferences synced. BUG=275988 TEST=Run Chromium; do (from command line): "defaults read org.chromium.Chromium LastRunAppBundlePath" -- should get path to Chromium.app; move Chromium.app to another location and run it again; do "defaults ..." again -- should get path to Chromium.app at new location. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220168

Patch Set 1 #

Total comments: 1

Patch Set 2 : Call RecordLastRunAppBundlePath immediately #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jiang Jiang
7 years, 4 months ago (2013-08-22 09:22:06 UTC) #1
Nico
Thanks for working on this! One effect of this change is that kLastRunAppBundlePathPrefsKey is now ...
7 years, 4 months ago (2013-08-22 14:00:10 UTC) #2
tapted
https://codereview.chromium.org/22966010/diff/1/chrome/browser/app_controller_mac.mm File chrome/browser/app_controller_mac.mm (right): https://codereview.chromium.org/22966010/diff/1/chrome/browser/app_controller_mac.mm#newcode171 chrome/browser/app_controller_mac.mm:171: chrome::GetVersionedDirectory().DirName().DirName().DirName(); drive-by: Is there an issue down the code ...
7 years, 4 months ago (2013-08-22 23:28:04 UTC) #3
Jiang Jiang
On 2013/08/22 14:00:10, Nico (vacation Aug 2 - Aug 22) wrote: > Thanks for working ...
7 years, 4 months ago (2013-08-23 08:00:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/22966010/8001
7 years, 3 months ago (2013-08-28 20:14:41 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 03:09:17 UTC) #6
Message was sent while issue was closed.
Change committed as 220168

Powered by Google App Engine
This is Rietveld 408576698