Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 22963002: Adds a flag to enable accessibility tab switcher. (Closed)

Created:
7 years, 4 months ago by clholgat
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds a flag to enable accessibility tab switcher. Adds a flag to show Android's accessibility tab switcher. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217674

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added if guard to generated_resources.grd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/22963002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/22963002/diff/1/chrome/app/generated_resources.grd#newcode5359 chrome/app/generated_resources.grd:5359: + <message name="IDS_FLAGS_ENABLE_ACCESSIBILITY_TAB_SWITCHER_NAME" desc="Name of the flag to ...
7 years, 4 months ago (2013-08-14 18:40:01 UTC) #1
clholgat
https://chromiumcodereview.appspot.com/22963002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/22963002/diff/1/chrome/app/generated_resources.grd#newcode5359 chrome/app/generated_resources.grd:5359: + <message name="IDS_FLAGS_ENABLE_ACCESSIBILITY_TAB_SWITCHER_NAME" desc="Name of the flag to enable ...
7 years, 4 months ago (2013-08-14 18:52:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clholgat@chromium.org/22963002/5001
7 years, 4 months ago (2013-08-14 20:13:52 UTC) #3
commit-bot: I haz the power
Change committed as 217674
7 years, 4 months ago (2013-08-14 22:18:56 UTC) #4
laurazinke56
7 years, 1 month ago (2013-11-04 22:34:08 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698