Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Issue 2296043003: Rename Lo-Fi previews to lite pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newLoFiInfoBarAddTests
Patch Set: tbansal comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
index b5a6c95709bf5950bf58aa03b242ab45ad9bb883..4f587056a7fe8fcb0bc44afd17d9e7e80668fc7d 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
@@ -319,16 +319,15 @@ void DataReductionProxyNetworkDelegate::OnCompletedInternal(
*request);
} else if (data_reduction_proxy_io_data_ && request->response_headers() &&
request->response_headers()->HasHeaderValue(
- chrome_proxy_header(),
- chrome_proxy_lo_fi_preview_directive())) {
- RecordLoFiTransformationType(PREVIEW);
+ chrome_proxy_header(), chrome_proxy_lite_page_directive())) {
+ RecordLitePageTransformationType(LITE_PAGE);
} else if (request->GetFullRequestHeaders(&request_headers) &&
request_headers.HasHeader(chrome_proxy_header())) {
std::string header_value;
request_headers.GetHeader(chrome_proxy_header(), &header_value);
- if (header_value.find(chrome_proxy_lo_fi_preview_directive()) !=
+ if (header_value.find(chrome_proxy_lite_page_directive()) !=
std::string::npos) {
- RecordLoFiTransformationType(NO_TRANSFORMATION_PREVIEW_REQUESTED);
+ RecordLitePageTransformationType(NO_TRANSFORMATION_LITE_PAGE_REQUESTED);
}
}
@@ -431,10 +430,10 @@ void DataReductionProxyNetworkDelegate::RecordContentLength(
}
}
-void DataReductionProxyNetworkDelegate::RecordLoFiTransformationType(
- LoFiTransformationType type) {
+void DataReductionProxyNetworkDelegate::RecordLitePageTransformationType(
+ LitePageTransformationType type) {
UMA_HISTOGRAM_ENUMERATION("DataReductionProxy.LoFi.TransformationType", type,
- LO_FI_TRANSFORMATION_TYPES_INDEX_BOUNDARY);
+ LITE_PAGE_TRANSFORMATION_TYPES_INDEX_BOUNDARY);
}
bool DataReductionProxyNetworkDelegate::WasEligibleWithoutHoldback(

Powered by Google App Engine
This is Rietveld 408576698