Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 22958002: [Sync] Fix disappearing passphrase box in setup (Closed)

Created:
7 years, 4 months ago by Nicolas Zea
Modified:
7 years, 4 months ago
Reviewers:
Raghu Simha
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

[Sync] Fix disappearing passphrase box in setup Custom passphrase container was being reset unnecessarily. BUG=271302 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217193

Patch Set 1 #

Patch Set 2 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/sync_setup_overlay.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
PTAL
7 years, 4 months ago (2013-08-12 22:13:42 UTC) #1
Raghu Simha
LGTM.
7 years, 4 months ago (2013-08-12 22:30:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/22958002/6001
7 years, 4 months ago (2013-08-12 22:34:27 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 04:31:02 UTC) #4
Message was sent while issue was closed.
Change committed as 217193

Powered by Google App Engine
This is Rietveld 408576698