Issue 22954004: autocomplete: Fix the use of std::remove_if() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22954004: autocomplete: Fix the use of std::remove_if() function. (Closed)

Created:
7 years, 4 months ago by tfarina

Modified:
7 years, 4 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

autocomplete: Fix the use of std::remove_if() function. To properly remove the items from the container we have to use the erase-remove-idiom, see wikipedia article http://en.wikipedia.org/wiki/Erase-remove_idiom. This fixes the problem as described in http://www.viva64.com/en/b/0205/#ID0ET6CI BUG=271541 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217179

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/autocomplete/shortcuts_provider.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/22954004/1002

7 years, 4 months ago (2013-08-12 23:48:24 UTC) #3

tfarina

7 years, 4 months ago (2013-08-13 03:18:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r217179 (presubmit successful).