Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7536)

Unified Diff: chromeos/network/network_connection_handler.cc

Issue 22950007: Insufficient information on activation details should be handled correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit, added some other changes that fell into this CL. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_connection_handler.cc
diff --git a/chromeos/network/network_connection_handler.cc b/chromeos/network/network_connection_handler.cc
index afbd741d1202660ef8db97d32b954017d066f9d0..0348987235691930df485202064c78e588ec4548 100644
--- a/chromeos/network/network_connection_handler.cc
+++ b/chromeos/network/network_connection_handler.cc
@@ -57,8 +57,8 @@ void CopyStringFromDictionary(const base::DictionaryValue& source,
bool NetworkRequiresActivation(const NetworkState* network) {
return (network->type() == flimflam::kTypeCellular &&
- (network->activation_state() != flimflam::kActivationStateActivated ||
- network->cellular_out_of_credits()));
+ ((network->activation_state() != flimflam::kActivationStateActivated &&
+ network->activation_state() != flimflam::kActivationStateUnknown)));
}
bool VPNIsConfigured(const std::string& service_path,

Powered by Google App Engine
This is Rietveld 408576698