Insufficient information on activation details should be handled correctly.

Insufficient information on activation details should be handled correctly.
    
This CL makes the following two changes for the case where the service property
"Cellular.ActivationState" has value "flimflam::kActivationStateUnknown" and
payment portal URL is unavailable:
    
  1. NetworkConnectionHandler won't fail to connect with an activation error.
  2. InternetOptionsHandler will hide the "View Account" and "Activate" buttons
         if a payment portal URL is unavailable.
    
This CL also removes the NetworkConnectionHandler behavior that causes
a connect operation to fail with an activation related error when
Cellular.OutOfCredits is set to true, which leads to a confusing user
experience.
    
BUG=272324
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217759

[stevenjb, 2013-08-14 17:48:52]

lgtm

https://codereview.chromium.org/22950007/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/22950007/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1785:
std::string url;
nit: support_url

[armansito, 2013-08-14 23:12:00]

Made some additional changes, PTAL.

https://codereview.chromium.org/22950007/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/22950007/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:1785:
std::string url;
On 2013/08/14 17:48:53, stevenjb (chromium) wrote:
> nit: support_url

Done.

[stevenjb, 2013-08-14 23:19:23]

Changes LGTM

https://codereview.chromium.org/22950007/diff/6001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/22950007/diff/6001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_connect.cc:277: service_path);
nit: {} around multi-line statement

[armansito, 2013-08-15 00:35:36]

https://codereview.chromium.org/22950007/diff/6001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/22950007/diff/6001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_connect.cc:277: service_path);
On 2013/08/14 23:19:23, stevenjb (chromium) wrote:
> nit: {} around multi-line statement

Oh, this is not a multi-line statement. We show mobile setup if the payment url
is available. We return early either way.

[commit-bot: I haz the power, 2013-08-15 03:34:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/22950007/6001

[commit-bot: I haz the power, 2013-08-15 03:43:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/22950007/6001

[commit-bot: I haz the power, 2013-08-15 07:19:52]

Change committed as 217759