Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 22949002: [CSS Grid Layout] Avoid preferred logical widths' recomputations (Closed)

Created:
6 years, 4 months ago by Julien - ping for review
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, ojan, esprehn
Visibility:
Public.

Description

[CSS Grid Layout] Avoid preferred logical widths' recomputations The code runs the content-sized track sizing algorithm all the time, which forces a layout even when the track is not content-sized. This change makes us bail out if we know we don't need to run the algorithm. Note that it will not help content sized grid tracks. This speeds up PerformanceTests/Layout/fixed-grid-lots-of-data.html from ~28.5 run/s to ~585 run/s by avoiding a lot of unneeded layouts. The baselines change comes from triggering less layouts, which changes the frame rects between 2 subsequent layouts thus changing the repaint rectangles. BUG=225892 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2042 lines, -0 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A PerformanceTests/Layout/fixed-grid-lots-of-data.html View 1 chunk +2037 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Julien - ping for review
6 years, 4 months ago (2013-08-12 22:48:23 UTC) #1
ojan
lgtm
6 years, 4 months ago (2013-08-12 22:50:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22949002/1
6 years, 4 months ago (2013-08-12 22:51:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22949002/1
6 years, 4 months ago (2013-08-13 16:44:06 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2013-08-13 16:44:56 UTC) #5
Message was sent while issue was closed.
Change committed as 156028

Powered by Google App Engine
This is Rietveld 408576698