Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 22940002: Disable tabCapture API tests on Windows. Seem to be broken since a libjingle roll. (Closed)

Created:
7 years, 4 months ago by justinlin
Modified:
7 years, 4 months ago
Reviewers:
miu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Disable tabCapture API tests on Windows. Seem to be broken since a libjingle roll. BUG=263951 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
justinlin
7 years, 4 months ago (2013-08-12 20:57:30 UTC) #1
miu
lgtm, but needs immediate attention for re-enable, IMHO.
7 years, 4 months ago (2013-08-12 21:00:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/22940002/1
7 years, 4 months ago (2013-08-12 21:04:29 UTC) #3
justinlin
On 2013/08/12 21:04:29, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 4 months ago (2013-08-12 23:29:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/22940002/1
7 years, 4 months ago (2013-08-12 23:40:13 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-13 00:03:31 UTC) #6
Message was sent while issue was closed.
Change committed as 217125

Powered by Google App Engine
This is Rietveld 408576698