Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2122)

Unified Diff: chrome/browser/resources/extensions/extension_error.js

Issue 22938005: Add ErrorConsole UI for Extension Install Warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_install_warnings
Patch Set: Dan's Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_error.js
diff --git a/chrome/browser/resources/extensions/extension_error.js b/chrome/browser/resources/extensions/extension_error.js
new file mode 100644
index 0000000000000000000000000000000000000000..28d5bbb4bad1676884af661c9a622d1c58d95589
--- /dev/null
+++ b/chrome/browser/resources/extensions/extension_error.js
@@ -0,0 +1,204 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+cr.define('extensions', function() {
+ 'use strict';
+
+ /**
+ * Returns whether or not a given |url| is associated with an extension.
+ * @param {string} url The url to examine.
+ * @param {string} extensionUrl The url of the extension.
+ * @return {boolean} Whether or not the url is associated with the extension.
+ */
+ function isExtensionUrl(url, extensionUrl) {
+ return url.substring(0, extensionUrl.length) == extensionUrl;
+ }
+
+ /**
+ * Get the url relative to the main extension url. If the url is
+ * unassociated with the extension, this will be the full url.
+ * @param {string} url The url to make relative.
+ * @param {string} extensionUrl The host for which the url is relative.
+ * @return {string} The url relative to the host.
+ */
+ function getRelativeUrl(url, extensionUrl) {
+ return isExtensionUrl(url, extensionUrl) ?
+ url.substring(extensionUrl.length) : url;
+ }
+
+ /**
+ * Clone a template within the extension error template collection.
+ * @param {string} templateName The class name of the template to clone.
+ * @return {HTMLElement} The clone of the template.
+ */
+ function cloneTemplate(templateName) {
+ return $('template-collection-extension-error').
+ querySelector(templateName).cloneNode(true);
+ }
+
+ /**
+ * Creates a new ExtensionError HTMLElement.
+ * @param {Object} error The error the element should represent.
+ * @constructor
+ * @extends {HTMLDivElement}
+ */
+ function ExtensionError(error) {
+ var div = document.createElement('div');
+ div.__proto__ = ExtensionError.prototype;
+ div.className = 'extension-error-simple-wrapper';
+ div.error_ = error;
+ div.decorate();
+ return div;
+ }
+
+ ExtensionError.prototype = {
+ __proto__: HTMLDivElement.prototype,
+
+ /** @override */
+ decorate: function() {
+ var metadata = cloneTemplate('.extension-error-metadata');
+
+ // Set an icon for the level of severity.
+ var iconNode = document.createElement('img');
+ if (this.error_.level == 0)
+ iconNode.className = 'extension-error-icon-log';
+ else if (this.error_.level == 1)
+ iconNode.className = 'extension-error-icon-warn';
+ else
+ iconNode.className = 'extension-error-icon-error';
+
+ metadata.insertBefore(iconNode, metadata.firstChild);
+
+ // Add a property for the extension's base url in order to determine if
+ // a url belongs to the extension.
+ this.extensionUrl_ =
+ 'chrome-extension://' + this.error_.extensionId + '/';
+
+ metadata.querySelector('.extension-error-message').innerText =
+ this.error_.message;
+
+ metadata.querySelector('.extension-error-source').innerText =
+ '(' + getRelativeUrl(this.error_.source, this.extensionUrl_) + ')';
+
+ this.appendChild(metadata);
+ this.addViewLinkToNode_(this, this.error_.source);
+ },
+
+ /**
+ * Add a "view" link to the given node, if a user can view the source of the
+ * specified url.
+ * @param {HTMLElement} node The node to which we append the view link.
+ * @param {string} url The url to the resource to view.
+ * @private
+ */
+ addViewLinkToNode_: function(node, url) {
+ if (this.canViewSource_(url))
+ node.appendChild(this.getViewSourceLink_(url));
+ },
+
+ /**
+ * Determine whether we can view the source of a given url.
+ * @param {string} url The url to the resource to view.
+ * @return {boolean} Whether or not we can view the source for the url.
+ * @private
+ */
+ canViewSource_: function(url) {
+ return isExtensionUrl(url, this.extensionUrl_) ||
+ url == 'manifest.json';
Dan Beam 2013/08/21 23:41:03 nit: think this fits in one line
Devlin 2013/08/22 18:29:06 Done.
+ },
+
+ /**
+ * Create a clickable node to view the source for the given url.
+ * @param {string} url The url to the resource to view.
+ * @return {HTMLElement} The clickable node to view the source.
+ * @private
+ */
+ getViewSourceLink_: function(url) {
+ var node = document.createElement('a');
+ node.innerText = loadTimeData.getString('extensionErrorViewSource');
+
+ var relativeLink = getRelativeUrl(url, this.extensionUrl_);
+ node.addEventListener('click', function(e) {
+ chrome.send('extensionErrorRequestFileSource',
+ [{'extensionId': this.error_.extensionId,
+ 'errorMessage': this.error_.message,
+ 'fileType': 'manifest',
+ 'pathSuffix': relativeLink,
+ 'feature': this.error_.manifestKey,
+ 'specific': this.error_.manifestSpecific}]);
+ }.bind(this));
+ return node;
+ },
+ };
+
+ /**
+ * An ExtensionErrorList represents the list of either runtime or manifest
+ * errors for a given extension. Each item in the list is an ExtensionError
+ * object, with information about the error. The list will display up to
+ * |MAX_ERRORS_TO_SHOW_| errors, with the option to expand (and then shrink)
+ * the displayed portion. This is included as part of the Extension node in
+ * the ExtensionList in chrome://extensions, if errors are present.
+ * @constructor
+ * @extends {HTMLDivElement}
+ */
+ function ExtensionErrorList(errors) {
+ var div = cloneTemplate('.extension-error-list');
+ div.__proto__ = ExtensionErrorList.prototype;
+ div.errors_ = errors;
+ div.decorate();
+ return div;
+ }
+
+ ExtensionErrorList.prototype = {
+ __proto__: HTMLDivElement.prototype,
+
+ /**
+ * @private
+ * @const
Dan Beam 2013/08/21 23:41:03 nit: forgot @type {number}
Devlin 2013/08/22 18:29:06 Done.
+ */
+ MAX_ERRORS_TO_SHOW_: 3,
+
+ /** @override */
+ decorate: function() {
+ this.contents_ = this.querySelector('.extension-error-list-contents');
+ this.errors_.forEach(function(error) {
+ this.contents_.appendChild(document.createElement('li')).appendChild(
+ new ExtensionError(error));
+ }, this);
+
+ if (this.contents_.children.length > this.MAX_ERRORS_TO_SHOW_) {
+ for (var i = this.MAX_ERRORS_TO_SHOW_;
+ i < this.contents_.children.length; ++i) {
+ this.contents_.children[i].hidden = true;
+ }
+ this.initShowMoreButton_();
+ }
+ },
+
+ /**
+ * Initialize the "Show More" button for the error list, if there are more
+ * than |MAX_ERRORS_TO_SHOW_| errors in the list.
+ * @private
+ */
+ initShowMoreButton_: function() {
+ var button = this.querySelector('.extension-error-list-show-more a');
+ button.hidden = false;
+ button.isShowingAll = false;
+ button.addEventListener('click', function(e) {
+ for (var i = this.MAX_ERRORS_TO_SHOW_;
+ i < this.contents_.children.length; ++i) {
+ this.contents_.children[i].hidden = button.isShowingAll;
+ }
+ var message = button.isShowingAll ? 'extensionErrorsShowMore' :
+ 'extensionErrorsShowFewer';
+ button.innerText = loadTimeData.getString(message);
+ button.isShowingAll = !button.isShowingAll;
+ }.bind(this));
+ }
+ };
+
+ return {
+ ExtensionErrorList: ExtensionErrorList
+ };
+});

Powered by Google App Engine
This is Rietveld 408576698