Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 22929035: [Android] Adds CleanupReferenceTest to findbugs_exclude.xml (Closed)

Created:
7 years, 4 months ago by gkanwar1
Modified:
7 years, 4 months ago
Reviewers:
joth
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, frankf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Adds CleanupReferenceTest to findbugs_exclude.xml NOTRY=True BUG=277682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/android/findbugs_filter/findbugs_exclude.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gkanwar1
ptal, findbugs appears to run successfully.
7 years, 4 months ago (2013-08-22 18:01:19 UTC) #1
joth
lgtm
7 years, 4 months ago (2013-08-22 18:44:02 UTC) #2
gkanwar1
On 2013/08/22 18:44:02, joth wrote: > lgtm Landing with NOTRY, since this is specific to ...
7 years, 4 months ago (2013-08-22 18:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gkanwar@chromium.org/22929035/1
7 years, 4 months ago (2013-08-22 18:54:51 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 19:09:05 UTC) #5
Message was sent while issue was closed.
Change committed as 219062

Powered by Google App Engine
This is Rietveld 408576698