Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 22929020: Dumping named grid line should use the author's order (Closed)

Created:
7 years, 4 months ago by Julien - ping for review
Modified:
7 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, esprehn, eseidel, ojan
Visibility:
Public.

Description

Dumping named grid line should use the author's order Before this change, we were using a semi-random order (based on the hashes' ordering inside the HashMap) to return the named grid lines in getComputedStyle. This made a test fragile and ultimately break under ASAN (because we don't have the same default size for HashMaps). The unspecified order also introduces a potential web compatibility risk. Tab Atkins was notified to make sure that it is corrected. BUG=270300 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -37 lines) Patch
M LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +11 lines, -22 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 3 chunks +15 lines, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleGridData.h View 3 chunks +7 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleGridData.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
7 years, 4 months ago (2013-08-21 01:13:08 UTC) #1
eseidel
lgtm ok
7 years, 4 months ago (2013-08-21 01:29:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22929020/1
7 years, 4 months ago (2013-08-21 01:30:05 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=2624
7 years, 4 months ago (2013-08-21 07:22:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22929020/1
7 years, 4 months ago (2013-08-21 15:20:44 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 15:21:22 UTC) #6
Message was sent while issue was closed.
Change committed as 156474

Powered by Google App Engine
This is Rietveld 408576698