Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: src/hydrogen-instructions.h

Issue 22926027: Fix dependency of loading the heap-number for a double-field store to be the mapcheck. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add store dependency Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5581 matching lines...) Expand 10 before | Expand all | Expand 10 after
5592 } 5592 }
5593 }; 5593 };
5594 5594
5595 5595
5596 class HLoadNamedField V8_FINAL : public HTemplateInstruction<1> { 5596 class HLoadNamedField V8_FINAL : public HTemplateInstruction<1> {
5597 public: 5597 public:
5598 DECLARE_INSTRUCTION_FACTORY_P2(HLoadNamedField, HValue*, HObjectAccess); 5598 DECLARE_INSTRUCTION_FACTORY_P2(HLoadNamedField, HValue*, HObjectAccess);
5599 5599
5600 HValue* object() { return OperandAt(0); } 5600 HValue* object() { return OperandAt(0); }
5601 bool HasTypeCheck() { return object()->IsCheckMaps(); } 5601 bool HasTypeCheck() { return object()->IsCheckMaps(); }
5602 void ClearTypeCheck() { SetOperandAt(0, object()->ActualValue()); }
5603 HObjectAccess access() const { return access_; } 5602 HObjectAccess access() const { return access_; }
5604 Representation field_representation() const { 5603 Representation field_representation() const {
5605 return access_.representation(); 5604 return access_.representation();
5606 } 5605 }
5607 5606
5608 virtual bool HasEscapingOperandAt(int index) V8_OVERRIDE { return false; } 5607 virtual bool HasEscapingOperandAt(int index) V8_OVERRIDE { return false; }
5609 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE { 5608 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
5610 if (index == 0 && access().IsExternalMemory()) { 5609 if (index == 0 && access().IsExternalMemory()) {
5611 // object must be external in case of external memory access 5610 // object must be external in case of external memory access
5612 return Representation::External(); 5611 return Representation::External();
(...skipping 1180 matching lines...) Expand 10 before | Expand all | Expand 10 after
6793 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 6792 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
6794 }; 6793 };
6795 6794
6796 6795
6797 #undef DECLARE_INSTRUCTION 6796 #undef DECLARE_INSTRUCTION
6798 #undef DECLARE_CONCRETE_INSTRUCTION 6797 #undef DECLARE_CONCRETE_INSTRUCTION
6799 6798
6800 } } // namespace v8::internal 6799 } } // namespace v8::internal
6801 6800
6802 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6801 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« src/hydrogen-escape-analysis.cc ('K') | « src/hydrogen-escape-analysis.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698