Issue 22926011: Add doctype declarations when using PageSerializer

Issue 22926011: Add doctype declarations when using PageSerializer (Closed)

Created:
7 years, 4 months ago by Tiger

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add doctype declarations when using PageSerializer Serialized pages were missing their doctypes. This can cause some pages to rendered incorrectly. R=abarth@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156781

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -9 lines)			Patch
M	Source/core/page/PageSerializer.cpp	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/web/tests/PageSerializerTest.cpp	View	1	2 chunks	+42 lines, -5 lines	0 comments	Download
A	Source/web/tests/data/pageserializer/dtd/dtd.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	Source/web/tests/data/pageserializer/xmldecl/xmldecl.xml	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/22926011/diff/1/Source/web/tests/PageSerializerTest.cpp File Source/web/tests/PageSerializerTest.cpp (right): https://codereview.chromium.org/22926011/diff/1/Source/web/tests/PageSerializerTest.cpp#newcode171 Source/web/tests/PageSerializerTest.cpp:171: return WTF::String(); No need for WTF:: Also, no ...

7 years, 4 months ago (2013-08-22 17:13:44 UTC) #2

Tiger

https://codereview.chromium.org/22926011/diff/1/Source/web/tests/PageSerializerTest.cpp File Source/web/tests/PageSerializerTest.cpp (right): https://codereview.chromium.org/22926011/diff/1/Source/web/tests/PageSerializerTest.cpp#newcode200 Source/web/tests/PageSerializerTest.cpp:200: setBaseFolder("pageserializer/xmldecl/"); On 2013/08/22 17:13:44, abarth wrote: > Why do ...

7 years, 3 months ago (2013-08-26 12:39:21 UTC) #3

abarth-chromium

On 2013/08/26 12:39:21, Tiger wrote: > There is no need for them to be in ...

7 years, 3 months ago (2013-08-26 19:24:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiger@opera.com/22926011/6001

7 years, 3 months ago (2013-08-27 10:20:27 UTC) #5

Message was sent while issue was closed.

Change committed as 156781

Expand Messages | Collapse Messages