Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2292303003: [Android] Remove close button on download manager's toolbar on tablet (Closed)

Created:
4 years, 3 months ago by Ian Wen
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove close button on download manager's toolbar on tablet On tablet this button does nothing. We should remove it. BUG=638111 Committed: https://crrev.com/9b97afa26f5ac9b108b504db1f7b49bd869d8e05 Cr-Commit-Position: refs/heads/master@{#415493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ian Wen
PTAL
4 years, 3 months ago (2016-08-30 22:18:36 UTC) #2
gone
cloooooddddde lgtm
4 years, 3 months ago (2016-08-30 22:26:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292303003/1
4 years, 3 months ago (2016-08-30 22:28:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 23:30:00 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 23:32:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b97afa26f5ac9b108b504db1f7b49bd869d8e05
Cr-Commit-Position: refs/heads/master@{#415493}

Powered by Google App Engine
This is Rietveld 408576698