Refactor MHTMLGenerator to allow getting sending the data to a file descriptor.

android_webview/native/aw_contents.cc

Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index e6cf84111a1b4098d9374cb2ab6d15a93cc37173..a0e7cd937b9e46cd7d061df32206c83da2e1f549 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -302,9 +302,10 @@ void AwContents::GenerateMHTML(JNIEnv* env, jobject obj,
                                jstring jpath, jobject callback) {
   ScopedJavaGlobalRef<jobject>* j_callback = new ScopedJavaGlobalRef<jobject>();
   j_callback->Reset(env, callback);
+  base::FilePath target_path(ConvertJavaStringToUTF8(env, jpath));
   web_contents_->GenerateMHTML(
-      base::FilePath(ConvertJavaStringToUTF8(env, jpath)),
-      base::Bind(&GenerateMHTMLCallback, base::Owned(j_callback)));
+      target_path,
+      base::Bind(&GenerateMHTMLCallback, base::Owned(j_callback), target_path));

[joth, 2013/08/28 19:02:37]

GenerateMHTMLCallback completely ignores the |path| parameter passed to it so
why not just remove it from the function rather than curry it in here?

[qsr, 2013/08/29 08:45:38]

 Which GenerateMHTMLCallback are you speaking about? The one just before this
use the path argument. If it's the java one you are speaking about, I did not go
look at it, but looking at this, it does use the path argument.

[joth, 2013/08/29 13:23:45]

Ah my mistake - I meant the one immediately above but I see it does use it after
all. Sorry for the bother!

 }
 
 void AwContents::PerformLongClick() {