chrome/browser/extensions/api/page_capture/page_capture_api.cc - Issue 22920005: Refactor MHTMLGenerator to allow getting sending the data to a file descriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 22920005: Refactor MHTMLGenerator to allow getting sending the data to a file descriptor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_contents.cc ('K') | « chrome/browser/extensions/api/page_capture/page_capture_api.h ('k') | content/browser/download/mhtml_generation_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc

diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

index 1fe87c7cbdb02272b749c9a46b7bc5fe4b1b5694..c40a19efb71fe8cb4f14bd24194659857c5d87cb 100644

--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc

+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

@@ -136,9 +136,7 @@ void PageCaptureSaveAsMHTMLFunction::TemporaryFileCreated(bool success) {

}

void PageCaptureSaveAsMHTMLFunction::MHTMLGenerated(

- const base::FilePath& file_path,

int64 mhtml_file_size) {

- DCHECK(mhtml_path_ == file_path);

if (mhtml_file_size <= 0) {

ReturnFailure(kMHTMLGenerationFailedError);

return;