Introduce facade for interaction with Android SurfaceTexture.

Introduce facade for interaction with Android SurfaceTexture.

Cleans up some of the JNI and makes usage of Android APIs more explicit.
BUG=261717
TBR=apatrick
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219061

[Yaron, 2013-08-21 22:14:22]

sievers: ui/gl/android (well everything if you want)
bulach: ui/android

Also, Marcus, if you have a better idea for resolving this (see bug for further
details), I'm open to it.

[bulach, 2013-08-22 09:25:40]

lgtm, thanks yaron!

when I chatted with cihat, I thought we could get away with an #ifdef of some
kind, but your patch is cleaner!
I just have one comment about renaming "Bridge" to something more specific in
the hopes it'll be kept as a thin wrapper, wdyt?

https://codereview.chromium.org/22912020/diff/1/ui/android/java/src/org/chrom...
File ui/android/java/src/org/chromium/ui/gfx/SurfaceTextureBridge.java (right):

https://codereview.chromium.org/22912020/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/gfx/SurfaceTextureBridge.java:16: class
SurfaceTextureBridge {
iirc we had this "bridge" before, but ended up removing it... it was more
complex though, and had actual logic in it..
so maybe to avoid it creeping up again, how about
"SurfaceTexturePlatformWrapper", with a comment saying that its only use is to
wrap the underlying platform's SurfaceTexture and provide a stable JNI API?

https://codereview.chromium.org/22912020/diff/1/ui/android/java/src/org/chrom...
ui/android/java/src/org/chromium/ui/gfx/SurfaceTextureBridge.java:53: // NOTE:
must only be called on API_LEVEL 16 and greater
we do remove java asserts on release builds, no? so maybe add one?

https://codereview.chromium.org/22912020/diff/1/ui/gl/android/surface_texture...
File ui/gl/android/surface_texture_listener.h (left):

https://codereview.chromium.org/22912020/diff/1/ui/gl/android/surface_texture...
ui/gl/android/surface_texture_listener.h:39: // SurfaceTexture instance.
maybe keep this comment in the constructor? it still holds that this class is
not owned by native..

[Yaron, 2013-08-22 18:17:20]

Happy to rename but I'll do it in a follow-up to ease merging (lots of places
refer to the native side). Also want sievers thumbs up on the rename

https://codereview.chromium.org/22912020/diff/1/ui/gl/android/surface_texture...
File ui/gl/android/surface_texture_listener.h (left):

https://codereview.chromium.org/22912020/diff/1/ui/gl/android/surface_texture...
ui/gl/android/surface_texture_listener.h:39: // SurfaceTexture instance.
On 2013/08/22 09:25:40, bulach wrote:
> maybe keep this comment in the constructor? it still holds that this class is
> not owned by native..

Done.

[no sievers, 2013-08-22 18:36:40]

lgtm

https://codereview.chromium.org/22912020/diff/8001/ui/android/java/src/org/ch...
File ui/android/java/src/org/chromium/ui/gfx/SurfaceTextureListener.java
(right):

https://codereview.chromium.org/22912020/diff/8001/ui/android/java/src/org/ch...
ui/android/java/src/org/chromium/ui/gfx/SurfaceTextureListener.java:17: private
int mNativeSurfaceTextureListener = 0;
nit: final

[Yaron, 2013-08-22 18:44:42]

tbr apatrick for simple gyp change. Landing notry as only cosmetic change since
patchset 1 and android-only

[commit-bot: I haz the power, 2013-08-22 18:54:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/22912020/19001

[commit-bot: I haz the power, 2013-08-22 19:08:36]

Change committed as 219061