Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 22912014: Correctly use IsThreadedCompositingEnabled in content_browsertests (Closed)

Created:
7 years, 4 months ago by piman
Modified:
7 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Correctly use IsThreadedCompositingEnabled in content_browsertests Content-level defaults should be set direclty inside of content, not in chrome. Also remove redundant setting of WebPreferences::force_compositing_mode in ChromeContentBrowserClient - it's already set in WebContentsImpl::GetWebkitPrefs. This allows us to remove compositor_util.h from the public API. BUG=276561 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -37 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/gpu/compositor_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download
D content/public/browser/compositor_util.h View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
7 years, 4 months ago (2013-08-20 21:28:31 UTC) #1
jamesr
lgtm
7 years, 4 months ago (2013-08-20 21:33:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/22912014/1
7 years, 4 months ago (2013-08-21 00:00:49 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 03:27:28 UTC) #4
Message was sent while issue was closed.
Change committed as 218619

Powered by Google App Engine
This is Rietveld 408576698