Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 22911032: Update connectivity diagnostics manifest (Closed)

Created:
7 years, 4 months ago by Zachary Kuznia
Modified:
7 years, 3 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Update connectivity diagnostics manifest BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221152

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Zachary Kuznia
Please take a look
7 years, 4 months ago (2013-08-21 22:45:40 UTC) #1
Dmitry Polukhin
https://codereview.chromium.org/22911032/diff/1/chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json File chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json (left): https://codereview.chromium.org/22911032/diff/1/chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json#oldcode13 chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json:13: "incognito": "split", Please make sure that incognito property is ...
7 years, 4 months ago (2013-08-21 22:51:46 UTC) #2
Dmitry Polukhin
LGTM with nit
7 years, 4 months ago (2013-08-21 22:54:29 UTC) #3
Zachary Kuznia
https://codereview.chromium.org/22911032/diff/1/chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json File chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json (left): https://codereview.chromium.org/22911032/diff/1/chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json#oldcode13 chrome/browser/resources/chromeos/connectivity_diagnostics/manifest.json:13: "incognito": "split", On 2013/08/21 22:51:46, Dmitry Polukhin wrote: > ...
7 years, 4 months ago (2013-08-21 23:04:22 UTC) #4
Dmitry Polukhin
lgtm
7 years, 4 months ago (2013-08-21 23:04:54 UTC) #5
Dmitry Polukhin
lgtm
7 years, 4 months ago (2013-08-21 23:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/22911032/7001
7 years, 4 months ago (2013-08-21 23:08:05 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=161374
7 years, 4 months ago (2013-08-22 02:32:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/22911032/7001
7 years, 3 months ago (2013-09-04 00:03:43 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 04:49:11 UTC) #10
Message was sent while issue was closed.
Change committed as 221152

Powered by Google App Engine
This is Rietveld 408576698