Issue 22911018: Remove special case code for generalizing constants to fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22911018: Remove special case code for generalizing constants to fields. (Closed)

Created:
7 years, 4 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove special case code for generalizing constants to fields. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16275

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -260 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.h	View	7 chunks	+21 lines, -18 lines	0 comments	Download
M	src/objects.cc	View	16 chunks	+176 lines, -233 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/property.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

LGTM after offline discussion, but as said, someone with better knowledge of these internals should ...

7 years, 4 months ago (2013-08-20 09:25:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r16275.