Issue 22911004: Fix leak in generated credit card bubble tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22911004: Fix leak in generated credit card bubble tests. (Closed)

Created:
7 years, 4 months ago by Dan Beam

Modified:
7 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix leak in generated credit card bubble tests. R=estade@chromium.org BUG=271431 TEST=git try -b linux_heapcheck Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217150

Patch Set 1 #

Patch Set 2 : . #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -20 lines)			Patch
M	chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

fyi: this wasn't a problem in non-test code because showing a bubble hides any others.

7 years, 4 months ago (2013-08-12 19:41:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/22911004/5001

7 years, 4 months ago (2013-08-12 22:14:13 UTC) #4

Message was sent while issue was closed.

Change committed as 217150

Expand Messages | Collapse Messages