Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 22909048: Remove IBus specific hack from InputMethodIBus. (Closed)

Created:
7 years, 4 months ago by Seigo Nonaka
Modified:
7 years, 3 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org, kevers
Visibility:
Public.

Description

Remove IBus specific hack from InputMethodIBus. BUG=None TEST=None, just working fine. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M ui/base/ime/input_method_ibus.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_ibus.cc View 7 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
Hi Zach, could you take a look? This hack is blocking VK implementation. Thank you. ...
7 years, 4 months ago (2013-08-23 04:08:27 UTC) #1
Seigo Nonaka
friendly ping.
7 years, 3 months ago (2013-08-27 02:18:22 UTC) #2
Zachary Kuznia
lgtm
7 years, 3 months ago (2013-09-04 20:17:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/22909048/1
7 years, 3 months ago (2013-09-05 09:12:17 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 13:04:38 UTC) #5
Message was sent while issue was closed.
Change committed as 221394

Powered by Google App Engine
This is Rietveld 408576698