Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: Source/modules/notifications/Notification.h

Issue 22909013: Notification should not leak document. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add test expectation Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/Notification.h
diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h
index 3441885989304abd7d11de519fe7fc4f1ca0a847..560abce05be7c157e5890320edf3cb8224845c8b 100644
--- a/Source/modules/notifications/Notification.h
+++ b/Source/modules/notifications/Notification.h
@@ -33,7 +33,7 @@
#define Notification_h
#include "bindings/v8/ScriptWrappable.h"
-#include "core/dom/ActiveDOMObject.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/dom/EventNames.h"
#include "core/dom/EventTarget.h"
#include "core/loader/ThreadableLoaderClient.h"
@@ -63,7 +63,7 @@ class ResourceResponse;
class ScriptExecutionContext;
class ThreadableLoader;
-class Notification : public RefCounted<Notification>, public ScriptWrappable, public ActiveDOMObject, public EventTarget {
+class Notification : public RefCounted<Notification>, public ScriptWrappable, public ContextLifecycleObserver, public EventTarget {
WTF_MAKE_FAST_ALLOCATED;
public:
Notification();
@@ -122,9 +122,9 @@ public:
// EventTarget interface
virtual const AtomicString& interfaceName() const;
- virtual ScriptExecutionContext* scriptExecutionContext() const { return ActiveDOMObject::scriptExecutionContext(); }
+ virtual ScriptExecutionContext* scriptExecutionContext() const { return ContextLifecycleObserver::scriptExecutionContext(); }
- // ActiveDOMObject interface
+ // ContextLifecycleObserver interface
virtual void contextDestroyed();
void stopLoadingIcon();

Powered by Google App Engine
This is Rietveld 408576698