Issue 22909005: Remove unneeded const on updateOffsetIfNeeded method.

Issue 22909005: Remove unneeded const on updateOffsetIfNeeded method. (Closed)

Created:
7 years, 4 months ago by Bem Jones-Bey (adobe)

Modified:
7 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, esprehn, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unneeded const on updateOffsetIfNeeded method. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155975

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/core/rendering/RenderBlock.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/rendering/RenderBlock.cpp	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

esprehn

https://codereview.chromium.org/22909005/diff/1/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/22909005/diff/1/Source/core/rendering/RenderBlock.cpp#newcode4254 Source/core/rendering/RenderBlock.cpp:4254: m_offset = logicalRight; wtf, how was this const if ...

7 years, 4 months ago (2013-08-12 23:18:33 UTC) #2

Bem Jones-Bey (adobe)

On 2013/08/12 23:18:33, esprehn wrote: > https://codereview.chromium.org/22909005/diff/1/Source/core/rendering/RenderBlock.cpp > File Source/core/rendering/RenderBlock.cpp (right): > > https://codereview.chromium.org/22909005/diff/1/Source/core/rendering/RenderBlock.cpp#newcode4254 > ...

7 years, 4 months ago (2013-08-12 23:23:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/22909005/1

7 years, 4 months ago (2013-08-12 23:44:02 UTC) #5

Message was sent while issue was closed.

Change committed as 155975

Expand Messages | Collapse Messages