Change viewport error messages in preparation for use with @viewport rule

Change viewport error messages in preparation for use with @viewport rule

The error messages will soon be used for both @viewport and viewport related
meta tags, so make the text less meta tag specific.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156424

[rune, 2013-08-20 09:29:45]

I'm not sure if I get the reasoning behind this change. For @viewport
descriptors there will be two types of errors looking at your list.
Unrecognized/unknown descriptor, and invalid value for a known descriptor. I'm
not looking at the CL this is a preparation for, but why not keep the meta
viewport messages as they are and introduce two new error messages for
@viewport?

[kenneth.r.christiansen, 2013-08-20 09:41:34]

On 2013/08/20 09:29:45, rune wrote:
> I'm not sure if I get the reasoning behind this change. For @viewport
> descriptors there will be two types of errors looking at your list.
> Unrecognized/unknown descriptor, and invalid value for a known descriptor. I'm
> not looking at the CL this is a preparation for, but why not keep the meta
> viewport messages as they are and introduce two new error messages for
> @viewport?

Because when we transform viewport meta into @viewport we cannot really
differentiate and it doesn't really matter either.

I also find the new naming better and shorter, plus it was already used for
things not being "viewport" such as "handheldoptimized"

[rune, 2013-08-20 09:51:58]

On 2013/08/20 09:41:34, kenneth.r.christiansen wrote:
> On 2013/08/20 09:29:45, rune wrote:
> > I'm not sure if I get the reasoning behind this change. For @viewport
> > descriptors there will be two types of errors looking at your list.
> > Unrecognized/unknown descriptor, and invalid value for a known descriptor.
I'm
> > not looking at the CL this is a preparation for, but why not keep the meta
> > viewport messages as they are and introduce two new error messages for
> > @viewport?
> 
> Because when we transform viewport meta into @viewport we cannot really
> differentiate and it doesn't really matter either.

The thing is that meta viewport property/value pairs will always generate valid
@viewport descriptors, so they would always be caught as an error on the meta
viewport side of things. For the author, he will still think of it as meta
viewport values and not as translated @viewport descriptors?

I think using the term "descriptor" would be a good thing for errors in
@viewport descriptors.

> I also find the new naming better and shorter, plus it was already used for
> things not being "viewport" such as "handheldoptimized"

I don't care so much about the naming for meta tag errors.

[rune, 2013-08-20 11:36:59]

https://codereview.chromium.org/22908011/diff/10001/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/22908011/diff/10001/Source/core/dom/Document....
Source/core/dom/Document.cpp:2869: error |= isInvalidSeparator(buffer[i]);
This will never do anything since isSeparator is not true when
isInvalidSeparator is.

https://codereview.chromium.org/22908011/diff/10001/Source/core/dom/Document....
Source/core/dom/Document.cpp:2893: error |= isInvalidSeparator(buffer[i]);
This will never do anything since isSeparator is not true when
isInvalidSeparator is.

[rune, 2013-08-20 11:54:47]

Rubber stamp.

[darktears, 2013-08-20 11:59:35]

On 2013/08/20 11:54:47, rune wrote:
> Rubber stamp.

LGTM.

[commit-bot: I haz the power, 2013-08-20 18:56:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/22908...

[commit-bot: I haz the power, 2013-08-21 03:04:01]

Change committed as 156424