Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.h

Issue 2290603005: Trigger app banner when add to homescreen is pressed and WebAPKs are enabled. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_manager.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.h b/chrome/browser/android/webapps/add_to_homescreen_manager.h
index 39953335ee1b711fd696ade143ce58d8a6bf0f3f..34c120b88fa6de9cc8be587f4f4d657f65612221 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.h
@@ -74,6 +74,10 @@ class AddToHomescreenManager : public AddToHomescreenDataFetcher::Observer {
// data needed to add the shortcut.
void AddShortcut(const ShortcutInfo& info, const SkBitmap& icon);
+ // Called only when the AddToHomescreenDataFetcher has retrieved all of the
+ // data needed to install a WebAPK.
+ void CreateInfobar(const ShortcutInfo& info, const SkBitmap& icon);
gone 2016/08/31 18:12:46 CreateInfoBarForWebAPK()
Xi Han 2016/08/31 20:11:48 Done.
+
void RecordAddToHomescreen();
// AddToHomescreenDataFetcher::Observer:
@@ -90,6 +94,9 @@ class AddToHomescreenManager : public AddToHomescreenDataFetcher::Observer {
// in progress.
bool add_shortcut_pending_;
+ // Whether the site is WebAPK-compatible.
+ bool is_compatible_;
gone 2016/08/31 18:12:45 make the variable name explicitly is_webapk_compat
Xi Han 2016/08/31 20:11:48 Done.
+
// Fetches data required to add a shortcut.
scoped_refptr<AddToHomescreenDataFetcher> data_fetcher_;

Powered by Google App Engine
This is Rietveld 408576698