Issue 22903046: [Android] Fix device file push location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22903046: [Android] Fix device file push location (Closed)

Created:
7 years, 3 months ago by boliu

Modified:
7 years, 3 months ago

Reviewers:
craigdh, joth, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix device file push location On ICS, push location for Android WebView was: file:///mnt/sdcard/chrome/test/data/device_files/database_access.html And now is fixed to: file:///mnt/sdcard/chrome/test/data/webview/database_access.html BUG=277077 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219585

Patch Set 1 #

Patch Set 2 : enable aw tests #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -32 lines)			Patch
	M	android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java	View	1	5 chunks	+10 lines, -30 lines	0 comments	Download
	M	build/android/pylib/android_commands.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

boliu

Proposed fix. Of course I've only tested android webivew instrumentation tests locally. Pls make sure ...

7 years, 3 months ago (2013-08-26 17:30:35 UTC) #1

craigdh

lgtm, it seems directories were being provided without the trailing backslash and os.path.dirname() was stripping ...

7 years, 3 months ago (2013-08-26 18:01:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/22903046/5001

7 years, 3 months ago (2013-08-26 19:17:03 UTC) #5

Message was sent while issue was closed.

Change committed as 219585

Expand Messages | Collapse Messages