js accessor creation on Template

src/objects-inl.h

Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 169475791d05ff9672dfff163ba14dde0506bea5..b0defdf2995ef50075276e3046a8f0a71cfb012c 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -4440,6 +4440,7 @@ ACCESSORS(Box, value, Object, kValueOffset)
 
 ACCESSORS(AccessorPair, getter, Object, kGetterOffset)
 ACCESSORS(AccessorPair, setter, Object, kSetterOffset)
+ACCESSORS_TO_SMI(AccessorPair, flag, kFlagOffset)

[Sven Panne, 2013/08/21 10:46:25]

Can we rename this from plain "flag" to something more specific like
"access_flags"? (OK, this collides with the new method below, but you get the
idea.)

The name "flag" contains roughly as much information as "foo" or "hurz". :-)

As discussed offline: What were the results of measuring the number of
AccessorPairs in Chrome on typical web sites/applications?

[dcarney, 2013/08/21 10:59:33]

okay, but all the flag fields everywhere else are called flag
I haven't done it yet. I'm doing this first, and will extend the class hierarchy
if necessary in a follow up cl

 
 ACCESSORS(AccessCheckInfo, named_callback, Object, kNamedCallbackOffset)
 ACCESSORS(AccessCheckInfo, indexed_callback, Object, kIndexedCallbackOffset)
@@ -5836,6 +5837,36 @@ bool AccessorInfo::IsCompatibleReceiver(Object* receiver) {
 }
 
 
+void AccessorPair::set_access_flags(v8::AccessControl access_control) {
+  int current = flag()->value();
+  current = BooleanBit::set(current,
+                            kProhibitsOverwritingBit,
+                            access_control & PROHIBITS_OVERWRITING);
+  current = BooleanBit::set(current,
+                            kAllCanReadBit,
+                            access_control & ALL_CAN_READ);
+  current = BooleanBit::set(current,
+                            kAllCanWriteBit,
+                            access_control & ALL_CAN_WRITE);
+  set_flag(Smi::FromInt(current));
+}
+
+
+bool AccessorPair::all_can_read() {
+  return BooleanBit::get(flag(), kAllCanReadBit);
+}
+
+
+bool AccessorPair::all_can_write() {
+  return BooleanBit::get(flag(), kAllCanWriteBit);
+}
+
+
+bool AccessorPair::prohibits_overwriting() {
+  return BooleanBit::get(flag(), kProhibitsOverwritingBit);
+}
+
+
 template<typename Shape, typename Key>
 void Dictionary<Shape, Key>::SetEntry(int entry,
                                       Object* key,