Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 22901023: linux_aura: Fix crash when dragging NTP icons. (Closed)

Created:
7 years, 4 months ago by Elliot Glaysher
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

linux_aura: Fix crash when dragging NTP icons. While the title in a Mozilla style URL may not be optional, an empty title is indistinguishable from one without. BUG=277264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219173

Patch Set 1 #

Patch Set 2 : Add test and fix a small problem with SelectionFormatMap. #

Patch Set 3 : exclude files on chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M build/filename_rules.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +6 lines, -5 lines 0 comments Download
A ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download
M ui/base/x/selection_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
7 years, 4 months ago (2013-08-22 17:57:07 UTC) #1
sky
LGTM - test would be nice
7 years, 4 months ago (2013-08-22 18:05:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/22901023/5001
7 years, 4 months ago (2013-08-22 20:38:04 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-22 21:38:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/22901023/21001
7 years, 4 months ago (2013-08-22 21:47:24 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 01:12:41 UTC) #6
Message was sent while issue was closed.
Change committed as 219173

Powered by Google App Engine
This is Rietveld 408576698