Move remoting identity API client id into src-internal.

Move remoting identity API client id into src-internal.

This CL removes the client id from the apps V2 patch. There is a separate (not public) CL that adds a new one.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218132

[rmsousa, 2013-08-15 00:13:07]

lgtm w/ nit

https://chromiumcodereview.appspot.com/22901007/diff/1/remoting/webapp/appsv2...
File remoting/webapp/appsv2.patch (right):

https://chromiumcodereview.appspot.com/22901007/diff/1/remoting/webapp/appsv2...
remoting/webapp/appsv2.patch:55: +    "client_id":
"REMOTING_IDENTIY_API_CLIENT_ID",
typo (identity)

https://chromiumcodereview.appspot.com/22901007/diff/1/remoting/webapp/build-...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/22901007/diff/1/remoting/webapp/build-...
remoting/webapp/build-webapp.py:291: '"REMOTING_IDENTIY_API_CLIENT_ID"',
consistent typo :)

[Jói, 2013-08-15 09:26:07]

https://chromiumcodereview.appspot.com/22901007/diff/7001/remoting/webapp/bui...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/22901007/diff/7001/remoting/webapp/bui...
remoting/webapp/build-webapp.py:282: apiClientIdV2 =
google_api_keys.GetClientID('REMOTING_IDENTITY_API')
It would be good to also add this to the debugging aid at the end of
google_api_keys.py (where it prints all tokens).

Also, unless you are absolutely sure this token will never be used from C++
code, google_api_keys.h and .cc should be updated.

[Jamie, 2013-08-15 18:29:58]

https://chromiumcodereview.appspot.com/22901007/diff/1/remoting/webapp/build-...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/22901007/diff/1/remoting/webapp/build-...
remoting/webapp/build-webapp.py:291: '"REMOTING_IDENTIY_API_CLIENT_ID"',
On 2013/08/15 00:13:07, rmsousa wrote:
> consistent typo :)

That explains why this didn't work until I copy/pasted the string from one place
to the other. :)

https://chromiumcodereview.appspot.com/22901007/diff/7001/remoting/webapp/bui...
File remoting/webapp/build-webapp.py (right):

https://chromiumcodereview.appspot.com/22901007/diff/7001/remoting/webapp/bui...
remoting/webapp/build-webapp.py:282: apiClientIdV2 =
google_api_keys.GetClientID('REMOTING_IDENTITY_API')
On 2013/08/15 09:26:08, Jói wrote:
> It would be good to also add this to the debugging aid at the end of
> google_api_keys.py (where it prints all tokens).

Done.

> Also, unless you are absolutely sure this token will never be used from C++
> code, google_api_keys.h and .cc should be updated.

I'm as certain as one can ever be about the future. Also, since there's no
corresponding secret, I think adding it to an API that's symmetric in terms of
client id and secret might be more misleading than helpful. LMK if you disagree
and I'll add it anyway.

[commit-bot: I haz the power, 2013-08-15 22:21:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/22901007/11001

[commit-bot: I haz the power, 2013-08-15 22:31:54]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Jamie, 2013-08-15 23:24:53]

Joi, the test code you wanted needs OWNERS approval :)

[Jói, 2013-08-16 09:45:49]

LGTM, thanks.

[commit-bot: I haz the power, 2013-08-16 09:46:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/22901007/11001

[commit-bot: I haz the power, 2013-08-16 09:46:28]

Failed to apply patch for google_apis/google_api_keys.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file google_apis/google_api_keys.py
  Hunk #1 FAILED at 88.
  1 out of 1 hunk FAILED -- saving rejects to file
google_apis/google_api_keys.py.rej

Patch:       google_apis/google_api_keys.py
Index: google_apis/google_api_keys.py
diff --git a/google_apis/google_api_keys.py b/google_apis/google_api_keys.py
index
6776aaec343b3d4e8497e3716f2c8ba295ab8130..87db0a57d2f53dfa552e9b0164e2771a282ac5fd
100755
--- a/google_apis/google_api_keys.py
+++ b/google_apis/google_api_keys.py
@@ -88,3 +88,5 @@ if __name__ == "__main__":
   print 'GOOGLE_CLIENT_SECRET_CLOUD_PRINT=%s' % GetClientSecret('CLOUD_PRINT')
   print 'GOOGLE_CLIENT_ID_REMOTING=%s' % GetClientID('REMOTING')
   print 'GOOGLE_CLIENT_SECRET_REMOTING=%s' % GetClientSecret('REMOTING')
+  print ('GOOGLE_CLIENT_ID_REMOTING_IDENTITY_API=%s' %
+         GetClientID('REMOTING_IDENTITY_API'))

[commit-bot: I haz the power, 2013-08-16 17:02:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/22901007/23001

[commit-bot: I haz the power, 2013-08-16 17:02:26]

Failed to apply patch for google_apis/google_api_keys.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file google_apis/google_api_keys.py
  Hunk #1 FAILED at 88.
  1 out of 1 hunk FAILED -- saving rejects to file
google_apis/google_api_keys.py.rej

Patch:       google_apis/google_api_keys.py
Index: google_apis/google_api_keys.py
diff --git a/google_apis/google_api_keys.py b/google_apis/google_api_keys.py
index
6776aaec343b3d4e8497e3716f2c8ba295ab8130..87db0a57d2f53dfa552e9b0164e2771a282ac5fd
100755
--- a/google_apis/google_api_keys.py
+++ b/google_apis/google_api_keys.py
@@ -88,3 +88,5 @@ if __name__ == "__main__":
   print 'GOOGLE_CLIENT_SECRET_CLOUD_PRINT=%s' % GetClientSecret('CLOUD_PRINT')
   print 'GOOGLE_CLIENT_ID_REMOTING=%s' % GetClientID('REMOTING')
   print 'GOOGLE_CLIENT_SECRET_REMOTING=%s' % GetClientSecret('REMOTING')
+  print ('GOOGLE_CLIENT_ID_REMOTING_IDENTITY_API=%s' %
+         GetClientID('REMOTING_IDENTITY_API'))

[commit-bot: I haz the power, 2013-08-16 17:33:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/22901007/27001

[commit-bot: I haz the power, 2013-08-17 00:47:07]

Change committed as 218132