Fixing race conditions in chrome.alarms

chrome/renderer/resources/extensions/last_error.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var GetAvailability = requireNative('v8_context').GetAvailability;
 var GetGlobal = requireNative('sendRequest').GetGlobal;
 
 // Utility for setting chrome.*.lastError.
 //
 // A utility here is useful for two reasons:
 //  1. For backwards compatibility we need to set chrome.extension.lastError,
 //     but not all contexts actually have access to the extension namespace.
 //  2. When calling across contexts, the global object that gets lastError set
 //     needs to be that of the caller. We force callers to explicitly specify
 //     the chrome object to try to prevent bugs here.
 
 /**
  * Sets the last error for |name| on |targetChrome| to |message| with an
  * optional |stack|.
  */
 function set(name, message, stack, targetChrome) {
   var errorMessage = name + ': ' + message;
   if (stack != null && stack != '')
     errorMessage += '\n' + stack;
 
   if (!targetChrome)
     throw new Error('No chrome object to set error: ' + errorMessage);
   clear(targetChrome);  // in case somebody has set a sneaky getter/setter
 
-  console.error(errorMessage);
-
   var errorObject = { message: message };
   if (GetAvailability('extension.lastError').is_available)
     targetChrome.extension.lastError = errorObject;
 
   assertRuntimeIsAvailable();
   targetChrome.runtime.lastError = errorObject;
 };
 
 /**
  * Clears the last error on |targetChrome|.
@@ skipping 33 matching lines @@
   try {
     $Function.apply(callback, undefined, args);
   } finally {
     clear(targetChrome);
   }
 }
 
 exports.clear = clear;
 exports.set = set;
 exports.run = run;