Fixing race conditions in chrome.alarms

Fixing race conditions in chrome.alarms.
This fix makes all alarms operations wait till alarms data is loaded from storage. Also fixing a bug in scheduling.

BUG=236684
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217750

[vadimt, 2013-08-15 00:50:44]

mpcomplete@, please provide OWNER's approval.
The exact delta between this change and the first fix attempt:
https://codereview.chromium.org/23071003/ (but please don't add comments there,
use the current review).

[Matt Perry, 2013-08-15 00:54:47]

Thanks for uploading the delta, too.

LGTM

[commit-bot: I haz the power, 2013-08-15 01:05:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vadimt@chromium.org/22900005/1

[commit-bot: I haz the power, 2013-08-15 05:45:59]

Change committed as 217750

[benwells, 2013-10-23 04:07:28]

On 2013/08/15 05:45:59, I haz the power (commit-bot) wrote:
> Change committed as 217750

Sorry to ask on such an old CL - but was the change to
chrome/renderer/resources/extensions/last_error.js intentional? It seems
unrelated to the description. This makes API errors no longer get logged to the
console.

[vadimt, 2013-10-23 16:03:51]

On 2013/10/23 04:07:28, benwells wrote:
> On 2013/08/15 05:45:59, I haz the power (commit-bot) wrote:
> > Change committed as 217750
> 
> Sorry to ask on such an old CL - but was the change to
> chrome/renderer/resources/extensions/last_error.js intentional? It seems
> unrelated to the description. This makes API errors no longer get logged to
the
> console.

Yes, this was intentional. This popped up during discussions about the main fix.
It's a normal practice, for example, to attempt to delete an alarm that doesn't
exist. This is useful when you want to kill an alarm, but don't know whether it
exists. The developer of the extension that does this should't be penalized by
red outputs in their Dev Tools console.
The bottom line is that an "error" from API doesn't always mean an error in the
application. If this is the case, the app is supposed to add its own error
output.