Issue 22900002: Cleanup: Do not check for NULL pointers returned by new in printing code.

Issue 22900002: Cleanup: Do not check for NULL pointers returned by new in printing code. (Closed)

Created:
7 years, 4 months ago by Lei Zhang

Modified:
7 years, 4 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Cleanup: Do not check for NULL pointers returned by new in printing code. See http://www.viva64.com/en/b/0205/ BUG=271530 R=vandebo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217938

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -19 lines)			Patch
	M	chrome/browser/printing/print_preview_dialog_controller.cc	View	1	3 chunks	+0 lines, -13 lines	0 comments	Download
	M	chrome/renderer/mock_printer.cc	View	1	2 chunks	+1 line, -6 lines	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/22900002/1

7 years, 4 months ago (2013-08-13 08:03:48 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-13 08:16:21 UTC) #4

Lei Zhang

In PrintPreviewDialogController, r144960 made |current_browser| necessary, but nobody ever noticed.

7 years, 4 months ago (2013-08-14 00:53:47 UTC) #5

vandebo (ex-Chrome)

On 2013/08/14 00:53:47, Lei Zhang wrote: > In PrintPreviewDialogController, r144960 made |current_browser| necessary, but > ...

7 years, 4 months ago (2013-08-15 21:29:36 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/22900002/24001

7 years, 4 months ago (2013-08-15 21:31:52 UTC) #8

Message was sent while issue was closed.

Change committed as 217938