Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 22897010: Add a virtual test suite for exposed "stable" features (Closed)

Created:
7 years, 4 months ago by Julien - ping for review
Modified:
7 years, 4 months ago
Reviewers:
Dirk Pranke, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Add a virtual test suite for exposed "stable" features This change removes enabling all the runtime enabled features in TestInterfaces. This code gone, we can use the new stable flag to add a test suite for "stable" features only (yay!). BUG=234853 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156570

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed the virtual test suite path per Eric and Dirk's suggestion. #

Patch Set 3 : Rebaselined change. #

Messages

Total messages: 10 (0 generated)
Julien - ping for review
Here is some "stable" testing bonanza for Blink!
7 years, 4 months ago (2013-08-21 15:22:09 UTC) #1
eseidel
lgtm https://codereview.chromium.org/22897010/diff/1/Tools/Scripts/webkitpy/layout_tests/port/chromium.py File Tools/Scripts/webkitpy/layout_tests/port/chromium.py (right): https://codereview.chromium.org/22897010/diff/1/Tools/Scripts/webkitpy/layout_tests/port/chromium.py#newcode355 Tools/Scripts/webkitpy/layout_tests/port/chromium.py:355: VirtualTestSuite('virtual/webexposed/stable', Did you mean for this to be ...
7 years, 4 months ago (2013-08-21 19:28:16 UTC) #2
Dirk Pranke
https://codereview.chromium.org/22897010/diff/1/Tools/Scripts/webkitpy/layout_tests/port/chromium.py File Tools/Scripts/webkitpy/layout_tests/port/chromium.py (right): https://codereview.chromium.org/22897010/diff/1/Tools/Scripts/webkitpy/layout_tests/port/chromium.py#newcode355 Tools/Scripts/webkitpy/layout_tests/port/chromium.py:355: VirtualTestSuite('virtual/webexposed/stable', On 2013/08/21 19:28:16, eseidel wrote: > Did you ...
7 years, 4 months ago (2013-08-21 21:53:05 UTC) #3
Julien - ping for review
https://codereview.chromium.org/22897010/diff/1/Tools/Scripts/webkitpy/layout_tests/port/chromium.py File Tools/Scripts/webkitpy/layout_tests/port/chromium.py (right): https://codereview.chromium.org/22897010/diff/1/Tools/Scripts/webkitpy/layout_tests/port/chromium.py#newcode355 Tools/Scripts/webkitpy/layout_tests/port/chromium.py:355: VirtualTestSuite('virtual/webexposed/stable', On 2013/08/21 21:53:05, Dirk Pranke wrote: > On ...
7 years, 4 months ago (2013-08-21 22:26:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22897010/10001
7 years, 4 months ago (2013-08-21 22:40:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=3015
7 years, 4 months ago (2013-08-22 00:23:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22897010/10001
7 years, 4 months ago (2013-08-22 16:42:18 UTC) #7
commit-bot: I haz the power
Failed to apply patch for LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; A LayoutTests/virtual/stable ...
7 years, 4 months ago (2013-08-22 16:42:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22897010/25001
7 years, 4 months ago (2013-08-22 17:38:42 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 18:52:33 UTC) #10
Message was sent while issue was closed.
Change committed as 156570

Powered by Google App Engine
This is Rietveld 408576698