Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 22895012: added WritePixelsBench (Closed)

Created:
7 years, 4 months ago by robertphillips
Modified:
7 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This bench attempts to recreate Chromium's Canvas_putImageData performance test to track down https://code.google.com/p/chromium/issues/detail?id=270649. Cranking the repitition count up to 500 on a MacPro yields: WITHOUT 10624: running bench [640 480] writepix_rgba_UPM 8888: cmsecs = 748.25 GPU: cmsecs = 225.95 gmsecs = 244.80 running bench [640 480] writepix_rgba_PM 8888: cmsecs = 54.12 GPU: cmsecs = 225.77 gmsecs = 244.59 WITH 10624: running bench [640 480] writepix_rgba_UPM 8888: cmsecs = 747.70 GPU: cmsecs = 230.30 gmsecs = 249.51 running bench [640 480] writepix_rgba_PM 8888: cmsecs = 55.05 GPU: cmsecs = 230.13 gmsecs = 249.38 Committed: http://code.google.com/p/skia/source/detail?r=10761

Patch Set 1 #

Patch Set 2 : fixed Mac bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
A bench/WritePixelsBench.cpp View 1 1 chunk +77 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 4 months ago (2013-08-15 20:10:59 UTC) #1
bsalomon
lgtm
7 years, 4 months ago (2013-08-15 20:40:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/22895012/3001
7 years, 4 months ago (2013-08-16 00:30:08 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 00:40:39 UTC) #4
Message was sent while issue was closed.
Change committed as 10761

Powered by Google App Engine
This is Rietveld 408576698